search

mozilla-releng / treestatus

Mozilla Public License 2.0
0 stars 10 forks source link

Fix error handling #13

Closed rail closed 4 years ago

rail commented 4 years ago

The implementation of the error handling function didn't properly handle connexion.problem type, which is quite different from werkzeug.exceptions.HTTPException. It doesn't have code attribute, what made the handler fall back to HTTP 500.

Fixes #5

codecov[bot] commented 4 years ago

Codecov Report

Merging #13 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          17     17           
  Lines        1091   1081   -10     
  Branches      169    167    -2     
=====================================
+ Misses       1091   1081   -10
Impacted Files Coverage Δ
api/src/treestatus_api/lib/api.py 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c092f53...38fbfee. Read the comment docs.

rail commented 4 years ago

Staging contains this code: https://stage.treestatus.mozilla-releng.net/trees/autoland/logs https://stage.treestatus.mozilla-releng.net/trees/autoland/logs?all=1 https://stage.treestatus.mozilla-releng.net/trees/autoland/logs?aaaaaall=1 All look good.