search

mozilla-sensorweb / sensorweb-server

Mozilla Public License 2.0
3 stars 6 forks source link

[Issue #45] Ignore clients auth redirection URLs if the request conta… #46

Closed ferjm closed 7 years ago

ferjm commented 7 years ago

…ins an empty array

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.111% when pulling f744deeddb59d2b2e747ec3c3f91aad7dcb07746 on ferjm:redirect_urls_2 into 71b32cac11d04dce6b3360627478b5b38cb25ae4 on mozilla-sensorweb:master.

julienw commented 7 years ago

My only concern is that we can have either an empty array or a NULL that mean the same; I feel like we should try to normalize this in a Client instance: if the array is empty, then expose it as null. What do you think ?

Otherwise there is a nit in the tests.

ferjm commented 7 years ago

Makes sense, I'll update the PR. Thanks

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 86.434% when pulling 4aa92d6742b828fac5435c8662ad6bcf1455feb6 on ferjm:redirect_urls_2 into 71b32cac11d04dce6b3360627478b5b38cb25ae4 on mozilla-sensorweb:master.