search

mozilla-services / Dockerflow

Cloud Services Dockerflow specification
Apache License 2.0
199 stars 28 forks source link

Update config.yml #41

Closed jvehent closed 4 years ago

jvehent commented 6 years ago

Alpine doesn't have git and openssh by default which breaks checkouts of git tags

mostlygeek commented 6 years ago

What does this fix? The circleci docker build succeeds.

jvehent commented 6 years ago

Circle2 fails to checkout git tags on that alpine container without those packages explicitely installed: https://circleci.com/gh/mozilla-services/autograph-edge/57

In discussions with @milescrabill, we suspect that Circle's fallback git implementation doesn't support tags.

milescrabill commented 6 years ago

Right, the theory is that without this PR merged, if you tag a release, the circleci build will fail on checkout.

mostlygeek commented 6 years ago

Just tried it by pushing a tag. I see the error message but it didn't break the build?

It made it all the way through to deploying the docker image as well.

mostlygeek commented 6 years ago

I wonder if this forum post sheds some light on the reason tags are broken...

I'm OK with merging this PR if we can have some comments about why installing we are installing git/ssh and avoiding the circleci custom one.

jvehent commented 6 years ago

Comment and link to forum discussion added

pjenvey commented 6 years ago

This can be closed now (I missed it and superseded it in #43)