search

mozilla-services / FindMyDevice

Find My Device - 🚨🚨This server is obsolete and unsupported.🚨🚨
Mozilla Public License 2.0
13 stars 8 forks source link

Remove imagemin #252

Closed nchapman closed 10 years ago

nchapman commented 10 years ago

Since we're committing optimized assets, imagemin is unnecessary.

nchapman commented 10 years ago

@pdehaan r?

pdehaan commented 10 years ago

Sounds good. Looking at an older Travis log (yay Travis), we weren't doing any image optims anyways:

Running "imagemin:dist" (imagemin) task
✔ app/images/nav-menu@2x.png (already optimized)
✔ app/images/nav-menu.png (already optimized)
✔ app/images/nav-forward@2x.png (already optimized)
✔ app/images/nav-forward.png (already optimized)
✔ app/images/nav-close@2x.png (already optimized)
✔ app/images/nav-back@2x.png (already optimized)
✔ app/images/nav-back.png (already optimized)
✔ app/images/nav-close.png (already optimized)
✔ app/images/icon-sound.png (already optimized)
✔ app/images/icon-sound@2x.png (already optimized)
✔ app/images/icon-sound-white@2x.png (already optimized)
✔ app/images/icon-sound-white.png (already optimized)
✔ app/images/icon-lock@2x.png (already optimized)
✔ app/images/icon-lock.png (already optimized)
✔ app/images/icon-lock-white@2x.png (already optimized)
✔ app/images/icon-lock-white.png (already optimized)
✔ app/images/icon-erase@2x.png (already optimized)
✔ app/images/icon-erase.png (already optimized)
✔ app/images/icon-erase-white@2x.png (already optimized)
✔ app/images/icon-erase-white.png (already optimized)
✔ app/images/icon-device@2x.png (already optimized)
✔ app/images/icon-device.png (already optimized)
✔ app/images/icon-device-active@2x.png (already optimized)
✔ app/images/icon-check@2x.png (already optimized)
✔ app/images/icon-device-active.png (already optimized)
✔ app/images/icon-check.png (already optimized)
✔ app/images/firefoxos@2x.png (already optimized)
✔ app/images/firefoxos.png (already optimized)
✔ app/images/pin-blank-located.png (already optimized)
✔ app/images/pin-blank.png (already optimized)
✔ app/images/pin-blank@2x.png (already optimized)
✔ app/images/pin-erase.png (already optimized)
✔ app/images/spinner-binoculars.png (already optimized)
✔ app/images/pin-erase-located.png (already optimized)
✔ app/images/pin-sound.png (already optimized)
✔ app/images/spinner-binoculars@2x.png (already optimized)
✔ app/images/pin-lost.png (already optimized)
✔ app/images/pin-erase@2x.png (already optimized)
✔ app/images/pin-sound-located.png (already optimized)
✔ app/images/pin-erase-located@2x.png (already optimized)
✔ app/images/pin-lost@2x.png (already optimized)
✔ app/images/pin-lost-located.png (already optimized)
✔ app/images/pin-sound@2x.png (already optimized)
✔ app/images/pin-blank-located@2x.png (already optimized)
✔ app/images/spinner.png (already optimized)
✔ app/images/spinner@2x.png (already optimized)
✔ app/images/pin-sound-located@2x.png (already optimized)
✔ app/images/pin-lost-located@2x.png (already optimized)
✔ app/images/bg.png (already optimized)
✔ app/images/bg@2x.png (already optimized)
Minified 50 images (saved 0 B)

Which seems like a waste of ~11s of Grunt-ing:

imagemin:dist   11.3s  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 29%
nchapman commented 10 years ago

Which seems like a waste of ~11s of Grunt-ing

Yup. Bring on the SPEEEEED.

pdehaan commented 10 years ago

:+1: