New home page - Githubissues

mozilla-services / FindMyDevice

Find My Device - 🚨🚨This server is obsolete and unsupported.🚨🚨

Mozilla Public License 2.0

13 stars 8 forks source link

Closed nchapman closed 9 years ago

nchapman commented 9 years ago

Fixes #70. This should be merged after #293.

pdehaan commented 9 years ago

Can you rebase this now that #293 has landed, and I can dig into why Travis is crying.

nchapman commented 9 years ago

@pdehaan turns out there was nothing to merge so this is ready for debugging!

pdehaan commented 9 years ago

Hhmm, not sure why this wouldn't need a rebase. Both PRs seemingly changed at least the .gitignore file.

nchapman commented 9 years ago

@pdehaan sorry you're so right. I ran the commands too fast and in the wrong order. Fixed now.

pdehaan commented 9 years ago

@nchapman Can you comment out the HTMLLint call on Gruntfile.js#L463 https://github.com/mozilla-services/FindMyDevice/pull/296/files#diff-f1cf363a582ec1740bed052de37ca1daR463 (or this line on Gruntfile.js#447 'lint:postbuild',). Both should kill the HTMLLint task until we can figure out why it's failing the build. I'll also check out https://github.com/alicoding/grunt-lint5 and see how it compares to HTML5 linting.

nchapman commented 9 years ago

@pdehaan linter has been disabled. I also fixed the IE 8 issues. Want to give this one more pass?

nchapman commented 9 years ago

Here are screenshots from popular devices and browsers:

pdehaan commented 9 years ago

LGTM. Lets merge this up and then get it on stage!