mozilla-services / FindMyDevice

Find My Device - 🚨🚨This server is obsolete and unsupported.🚨🚨
Mozilla Public License 2.0
13 stars 8 forks source link

Text can leak out of call-to-action buttons at certain widths/locales #308

Open pdehaan opened 9 years ago

pdehaan commented 9 years ago

Found in https://find.dev.mozaws.net/status/ (commit d99f37c)

{
    "goroutines": 11,
    "status": "ok",
    "version": "1.4-d99f37c"
}

Steps to reproduce:

  1. Set browser locale to Hungarian (hu).
  2. Go to https://find.dev.mozaws.net/
  3. Resize browser to 685px wide (this is the edge of the RWD breakpoint, so worst case scenario).

    Actual results:

eszkozkereso_ _firefox_os_ _mozilla Figure 1: The "Sign in" link in Hungarian (hu) — colored red for comedic effect.

Expected results:

No leaky buttons. Not sure how to solve that, given the translation is a single word. We could maybe resort to string truncation, which doesnt always degrade nicely, or just overflow:hidden.

nchapman commented 9 years ago

Get back inside the button you text! We might have to move these buttons into two lines at this res. It works side by side for English but seemingly for not many other languages.

nchapman commented 9 years ago

768px is the width I'm most concerned about. How does this look at that width?

pdehaan commented 9 years ago

Dearest Nicolas,

Enclosed, please find my screenshot of 768px for Hungarian.

eszkozkereso_ _firefox_os_ _mozilla

Yours forever, Peter M. deHaan, ESQ.