mozilla-services / FindMyDevice

Find My Device - 🚨🚨This server is obsolete and unsupported.🚨🚨
Mozilla Public License 2.0
13 stars 8 forks source link

Need a better "logo.png" image for oauth image_uri #76

Open pdehaan opened 10 years ago

pdehaan commented 10 years ago

Re: https://oauth.dev.lcip.org/v1/client/344e8ade775e8b15

{
  "name":  "Find My Device",
  "image_uri":  "http://fmd.dev.mozaws.net/static/logo.png",
  "redirect_uri": "http://fmd.dev.mozaws.net/authr"
}

I mean, it's pretty and all, but we'll probably need a better asset than this: TBD, BRO

pdehaan commented 10 years ago

STAND DOWN!!! Lets wait on fallout from mozilla/fxa-oauth-server#82 (in which I argue to remove image_uri from config since it is currently unused, unloved, and unwanted by UX/design team).

pdehaan commented 10 years ago

STAND BACK UP!!!

Per mozilla/fxa-oauth-server#82 we are keeping the config, which means we'll need a better image_uri in the off chance that we use it in the future we create a dashboard of sorts.

Here's the "prod-est" thing I can find at the moment: https://oauth.stage.mozaws.net/v1/client/cb62e277cf9de9b1

{
  "name": "Find My Device STAGE",
  "image_uri": "none",
  "redirect_uri": "https://fmd.stage.mozaws.net/oauth"
}

Looks like our handsome "TBD" marker image has been replaced with a placeholder "none" value in the database (which would no doubt be converted to a lovely 404 and broken image if we attempted to use it in real life).

Let's get Bryan's latest FMD logo (or whatever) and see if we can get @ckolos or somebody to update the image_uri in stage and ultimately oauth prod, if FMD is already listed in there.

jrgm commented 10 years ago

Actually, before I set the stage value to 'none', it was '', which was causing errors with fmd. But yeah, putting a real image url in there would be better than 'none'.