mozilla-services / autopush

Python Web Push Server used by Mozilla

https://autopush.readthedocs.io/

Mozilla Public License 2.0

217 stars 34 forks source link

Added Strict-Transport-Security header to 404s #1321

Closed psiinon closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #1321 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
+ Coverage   99.79%   99.79%   +<.01%     
==========================================
  Files          64       64              
  Lines       10392    10393       +1     
==========================================
+ Hits        10371    10372       +1     
  Misses         21       21

Impacted Files	Coverage Δ
autopush/web/base.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 956f7e4...94b4191. Read the comment docs.

psiinon commented 5 years ago

@jrconlin any idea when this will go to production?

jrconlin commented 5 years ago

We don't often push changes out, mostly because of limited QA time. If this is more urgent, I can see about doing a limited pull and get this started.

psiinon commented 5 years ago

it would be great if this could be pushed out before the end of the month, Q1 goals and all that ;)

jrconlin commented 5 years ago

Sadly, just missed the two week push cycle we have, however, since this is now out of your hands and we've got the bug for pushing this live, you can note this as done. ;) Not your problem anymore and folks can rightly yell at me.

https://bugzilla.mozilla.org/show_bug.cgi?id=1536536

Deployment to production should happen Apr. 03 or so.

On Wed, Mar 20, 2019, 8:25 AM Simon Bennetts notifications@github.com wrote:

it would be great if this could be pushed out before the end of the month, Q1 goals and all that ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla-services/autopush/pull/1321#issuecomment-474882995, or mute the thread https://github.com/notifications/unsubscribe-auth/AACLq7Pi08Hzb6Z_UaYKy3awslc2exmWks5vYlLRgaJpZM4bsz6y .

psiinon commented 5 years ago

OK no worries ;)