search

mozilla-services / autopush

Python Web Push Server used by Mozilla
https://autopush.readthedocs.io/
Mozilla Public License 2.0
217 stars 34 forks source link

feat: allow multi app-ids and auths for fcm #1344

Closed jrconlin closed 5 years ago

jrconlin commented 5 years ago

BREAKING CHANGE: This now supports multiple registrations for FCM. See the updated docs and sample configurations.

Obsolete configuration options:

New Configuration

fcm_creds={"_profile_": {"projectid": "_fcm_projectid_", "auth":
"_fcm_service_cred_path_"}}

v1 protocol is now the default.

for existing FCM, profile == _fcmprojectid

Closes #1340

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e404674). Click here to learn what that means. The diff coverage is 93.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1344   +/-   ##
=========================================
  Coverage          ?   99.71%           
=========================================
  Files             ?       64           
  Lines             ?    10445           
  Branches          ?        0           
=========================================
  Hits              ?    10415           
  Misses            ?       30           
  Partials          ?        0
Impacted Files Coverage Δ
autopush/tests/test_router.py 99.89% <100%> (ø)
autopush/main_argparse.py 100% <100%> (ø)
autopush/router/fcm_v1.py 100% <100%> (ø)
autopush/tests/test_z_main.py 100% <100%> (ø)
autopush/tests/test_integration.py 100% <100%> (ø)
autopush/web/webpush.py 99.24% <100%> (ø)
autopush/router/fcm.py 94.49% <71.42%> (ø)
autopush/config.py 98.52% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e404674...5147b5a. Read the comment docs.