search

mozilla-services / autopush

Python Web Push Server used by Mozilla
https://autopush.readthedocs.io/
Mozilla Public License 2.0
215 stars 34 forks source link

bug: do not require `encryption` header for APNs `aes128gcm` encoded messages #1385

Closed jrconlin closed 4 years ago

jrconlin commented 4 years ago

Description

Includes better logging for uncaught APNs errors, since those were getting dropped by cyclone.

Testing

Tests included in integration suite.

Issue(s)

Addresses Issue #1383 Closes #1384

pjenvey commented 4 years ago

Approved if you wanna get it out ASAP but I'd like to address those couple of things

codecov-io commented 4 years ago

Codecov Report

Merging #1385 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1385   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          64       64           
  Lines       10449    10476   +27     
=======================================
+ Hits        10422    10449   +27     
  Misses         27       27
Impacted Files Coverage Δ
autopush/router/apnsrouter.py 100.00% <100.00%> (ø)
autopush/tests/test_integration.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 688f0c0...0007d76. Read the comment docs.