codecov-commenter
commented
4 years ago Codecov Report
Merging #1401 into master will decrease coverage by
0.11%. The diff coverage is97.14%.
@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
- Coverage 99.74% 99.62% -0.12%
==========================================
Files 64 65 +1
Lines 10476 10467 -9
==========================================
- Hits 10449 10428 -21
- Misses 27 39 +12 | Impacted Files | Coverage Δ | |
|---|---|---|
| autopush/router/webpush.py | 100.00% <ø> (ø) |
|
| autopush/tests/test_router.py | 99.89% <ø> (-0.01%) |
:arrow_down: |
| autopush/tests/test_z_main.py | 100.00% <ø> (ø) |
|
| autopush/tests/test_integration.py | 99.79% <77.77%> (-0.21%) |
:arrow_down: |
| autopush/metrics.py | 100.00% <100.00%> (ø) |
|
| autopush/router/adm.py | 100.00% <100.00%> (ø) |
|
| autopush/router/apnsrouter.py | 100.00% <100.00%> (ø) |
|
| autopush/router/fcm.py | 97.05% <100.00%> (-0.03%) |
:arrow_down: |
| autopush/router/fcm_v1.py | 100.00% <100.00%> (ø) |
|
| autopush/router/gcm.py | 100.00% <100.00%> (ø) |
|
| ... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5538c22...4e9eacb. Read the comment docs.
jrconlin
Description
feat: Add tags back to metrics.
per ops request, this switches metrics to using markus. This also changes the DatadogMetrics library to TaggedMetrics, and becomes the default metrics library if the config value
statsd_hostis set.Testing
Unit tests provided.
Issue(s)
Closes #1400