search

mozilla-services / autopush

Python Web Push Server used by Mozilla
https://autopush.readthedocs.io/
Mozilla Public License 2.0
215 stars 34 forks source link

bug: Add integration tests to verify that updates do not alter reg info #1402

Closed jrconlin closed 4 years ago

jrconlin commented 4 years ago

Description

The original unit tests left questions as to whether or not an update() token change altered other data associated with the registered endpoint. Added integration tests to verify that the data remains consistent after a token update request is processed.

also fixed a typo, and due to a change in ssl handling, added some skip tests if an older cert is used.

Testing

This is a test.

Issue(s)

Closes #1397

codecov-commenter commented 4 years ago

Codecov Report

Merging #1402 into master will decrease coverage by 0.12%. The diff coverage is 80.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
- Coverage   99.74%   99.61%   -0.13%     
==========================================
  Files          64       65       +1     
  Lines       10476    10575      +99     
==========================================
+ Hits        10449    10534      +85     
- Misses         27       41      +14
Impacted Files Coverage Δ
autopush/tests/test_db.py 100.00% <ø> (ø)
autopush/web/registration.py 100.00% <ø> (ø)
autopush/tests/test_integration.py 99.20% <80.32%> (-0.80%) :arrow_down:
autopush/base.py 95.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d4c81b...94ca82c. Read the comment docs.