search

mozilla-services / axe-selenium-python

aXe Selenium Integration python package
https://pypi.python.org/pypi/axe-selenium-python/
Mozilla Public License 2.0
58 stars 50 forks source link

Modify write_results method to accept a path #155

Open kimberlythegeek opened 5 years ago

kimberlythegeek commented 5 years ago

Originally posted by @davehunt in https://github.com/mozilla-services/axe-selenium-python/pull/151

kimberlythegeek commented 5 years ago

davehunt a day ago Member

This hard-codes writing the file to the current working directory. Could there be a reason to want to write the file elsewhere? If so, it might make sense for write_results to take a path. Then the user can decide if they want it to be relative, or absolute, and can decide the destination. You could still default to current working directory if only a file name is provided, but you'd also need to handle when the destination does not exist. You can see an example of this in pytest-html https://github.com/pytest-dev/pytest-html/blob/master/pytest_html/plugin.py#L89-L90

terrameijar commented 5 years ago

Hi @kimberlythegeek I would like to work on this.