search

mozilla-services / axe-selenium-python

aXe Selenium Integration python package
https://pypi.python.org/pypi/axe-selenium-python/
Mozilla Public License 2.0
58 stars 50 forks source link

Add a test_write_results_without_filepath #159

Closed kimberlythegeek closed 4 years ago

kimberlythegeek commented 5 years ago

Should add a test to verify that write_results still works when no file name or path is given

kimberlythegeek commented 5 years ago

@terrameijar This occurred to me when reviewing your pr; feel free to pick this up if desired

terrameijar commented 5 years ago

@kimberlythegeek Thanks! On it.

terrameijar commented 5 years ago

I noticed that the test_write_results_to_file() test writes results data to a JSON file that doesn't get deleted at the end of the test. I think this file should be deleted after the test run is over. We can use the tempfile module to take care of removing the file after it has been read and the test is over. What do you think @kimberlythegeek ?

kimberlythegeek commented 5 years ago

@terrameijar Great idea! I hadn't thought of that :)

hzk120 commented 4 years ago

@kimberlythegeek Is this issue still open?, I would like to work on it if thats the case.

kimberlythegeek commented 4 years ago

apologies, @hzk120 , looks like this was fixed in #163