mozilla-services / axe-selenium-python

aXe Selenium Integration python package
https://pypi.python.org/pypi/axe-selenium-python/
Mozilla Public License 2.0
58 stars 50 forks source link

Added results filename to write to if user does not specify path #163

Closed terrameijar closed 5 years ago

terrameijar commented 5 years ago

@kimberlythegeek I noticed a mistake that I made when coding this. name should point to a user specified path, If it is None then we need to create results.json. I had not added this in the last commit.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 415


Totals Coverage Status
Change from base Build 407: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 408


Totals Coverage Status
Change from base Build 407: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls
terrameijar commented 5 years ago

The latest commit adds the test requested in https://github.com/mozilla-services/axe-selenium-python/issues/159 . I know this should have been a separate PR but I had already pushed to this branch and the changes showed up.

terrameijar commented 5 years ago

@kimberlythegeek flake8 error resolved.

m8ttyB commented 5 years ago

Merging this goodness, ty @terrameijar