coveralls
commented
5 years ago Closed RussellJQA closed 5 years ago
coveralls
commented
5 years ago coveralls
commented
5 years ago 
RussellJQA
commented
5 years ago I'm not familiar with Coverall coverage reports. Are the 2 reports basically just saying that the amount of code covered by the tests is unchanged by this pull request?
stephendonner
commented
5 years ago @RussellJQA yep
m8ttyB
commented
5 years ago Thank you @RussellJQA
RussellJQA
commented
5 years ago You're welcome @m8ttyB
Updated README.rst and axe_selenium_python/package-lock.json from axe-core 3.1.1 to 3.1.2, using "integrity" value copied from https://github.com/pa11y/pa11y-runner-axe/blob/master/package-lock.json
I copied https://cdnjs.cloudflare.com/ajax/libs/axe-core/3.1.2/axe.min.js to my local axe-selenium-python\axe_selenium_python\node_modules\axe-core\min.js.
And I tested with tox, but using just Python 3.7 (what I have installed) rather than both Python 2.7 and Python 3.6, by making a minor change to my local tox.ini file: @@ -1,7 +1,7 @@ [tox] -envlist = py27, py36, flake8 +envlist = py37, flake8
The axe tests passed, but there were some complaints from flake8: c:\projects\python\selenium\axe-selenium-python.tox\flake8\lib\site-packages\pycodestyle.py:113: FutureWarning: Possible nested set at position 1 EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]') .\setup.py:3:1: I001 isort found an import in the wrong position .\setup.py:5:1: I003 isort expected 1 blank line in imports, found 0 ...
Most of them seem similar to closed issue https://github.com/gforcada/flake8-isort/issues/65, which I don't understand since I'm running the latest version of flake8. But I don't think that's related to my changes. I've attached a copy of the tox output. tox.log