tracing-actix-web-mozlog: Semantic concerns (like adding request ID to the fields) should not be mixed with formatting concerns (logging as JSON)

mozilla-services / common-rs

Common utilities for Mozilla server side apps

Mozilla Public License 2.0

3 stars 9 forks source link

tracing-actix-web-mozlog: Semantic concerns (like adding request ID to the fields) should not be mixed with formatting concerns (logging as JSON) #27

Open mythmon opened 2 years ago

mythmon commented 2 years ago

Currently the JSON formatter performs several transformations of the data beyond formatting it as compatible JSON. This can be a problem for debugging or other environments that want to use human readable logs, but test the transformations that make this valid mozlog.

We should separate the two sets of concerns into two or more independent layers that can each be used separately.