search

mozilla-services / common-rs

Common utilities for Mozilla server side apps
Mozilla Public License 2.0
3 stars 9 forks source link

actix-web-location: document feature flags + add example #51

Closed robjtede closed 1 year ago

jrconlin commented 1 year ago

Looks good,

You can kill the audit warning by adding RUSTSEC-2023-0034 to the cargo/audit.toml file. Just add a comment tying it to actix-http 2.2.2

I'm not sure what to do about the test failing because cargo hack is bringing in both feature flags. That's a legit thing to fail on. I'm not super familiar with cargo hack so maybe it's better to do the less clever thing and just spell out the tests longhand for now? There's not that many permutations, so it should be fairly straight forward.

robjtede commented 1 year ago

That's a legit thing to fail on

Really the failure is that features are not strictly additive in this crate, but we've all committed this sin. Anyway, I've told CI to run them separately.

I'd actually suggest sunsetting the Actix Web v3 support as we're no longer supporting it.

jrconlin commented 1 year ago

Oh, sunsetting Actix3 is very much on my mind. The problem is that we have a few customer packages that still need it, so sigh might be a bit before we can do something draconian.