mozilla-services / contile

This is the back-end server for the Mozilla Tile Service (MTS)
https://mozilla-services.github.io/contile/
Mozilla Public License 2.0
19 stars 2 forks source link

[DISCO-2280] Add 'check-for-deployment' and 'unhold-to-deploy' jobs to the Contile CI main-workflow- #555

Closed taddes closed 1 year ago

taddes commented 1 year ago

References

JIRA: DISCO-2280 GitHub: #TODO

Description

In order to empower contributors to skip deployments (example: for documentation changes) and control the flow of changes to staging and production environments, introduce the check-for-deployment and unhold-to-deploy jobs to the Contile CI main-workflow.

Resource

Example: Merino CI workflows

Adding approval jobs to your CI pipeline

Acceptance Criteria

A check-for-deployment job is incorporated into the Contile CI main-workflow

It’s purpose is to detect the “[do not deploy]” text within the merge commit when merging the PR to the 'main' branch and to subsequently stop stage and production Docker Hub image publications.

An unhold-to-deploy job, or approval task, is incorporated into the Contile CI main-workflow

This job will wait for manual confirmation from a contributor before deploying the production Docker Hub images

The CONTRIBUTING.md, the PULL_REQUEST_TEMPLATE.md and any other relevant documentation is updated

PR Review Checklist

Put an x in the boxes that apply

taddes commented 1 year ago

Closing this PR as GitHub service degradation resulted in 2 commits not being signed. Opting to make new branch to push changes, opposed to bypassing merge protections. See: https://github.com/mozilla-services/contile/pull/558