mozilla-services / fx-sig-verify

DEPRECATED - Independent check of code signatures

Mozilla Public License 2.0

4 stars 13 forks source link

Add missing openssl dependency to README #77

Closed icaropires closed 4 years ago

icaropires commented 4 years ago

Closes #76

I've added the instructions for installing the needed Openssl packages at Ubuntu and Fedora to README.rst.

For Fedora I tested on my personal environment, with Fedora 31. And for the Ubuntu I've tested at a clean Docker container running the official Ubuntu image with Ubuntu 18.04.4.

codecov-io commented 4 years ago

Codecov Report

Merging #77 into master will not change coverage by %. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   73.05%   73.05%           
=======================================
  Files          30       30           
  Lines        1707     1707           
  Branches      234      234           
=======================================
  Hits         1247     1247           
  Misses        348      348           
  Partials      112      112

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4760719...2d07fab. Read the comment docs.

hwine commented 4 years ago

Thanks for the PR. The challenge with this approach is the need to constantly update it for each OS/version/package manager combination.

Also, this requires people modifying their system installation, which could conflict with other projects. (There aren't any "virtual env" setups for C code.)

Since we already require docker to build the production version, I think it will be more robust to document how to use docker for ad-hoc testing.

hwine commented 4 years ago

Used the approach in PR #78 -- thanks again for the report

icaropires commented 4 years ago

Nice chosen approach. I'm glad to help anyway!