search

mozilla-services / heka-py

DEPRECATED - Heka Python Library - DEPRECATED
28 stars 14 forks source link

strip out metlog features that nobody ever really used #2

Closed crankycoder closed 11 years ago

crankycoder commented 11 years ago

I'd like to delete a bunch of code that nobody has really used. This will both simplify the codebase and let us try to get closer to feature parity among the nodejs, python and go clients.

a) global_conf - for both firefox sync and marketplace, we're not using this at all. In the node.js (heka-node) client, we don't support this feature. I'd like to drop it to simplify things

b) dropping the StdlibLoggingSender

We've only ever used this for initial prototyping to route metlog messages to python stdlib logging. There's no use case for this that I can think of especially in the context of having heka-the-clent and heka-the-daemon.

For nodejs - we can't possibly support this feature. Note that this is not the HekaHandler that enabled python std logging to emit messages through heka.

crankycoder commented 11 years ago

I've just gone ahead and done this in the features/protobuf-header branch