HttpListenInput alters received data with url.QueryUnescape

mozilla-services / heka

DEPRECATED: Data collection and processing made easy.

http://hekad.readthedocs.org/

Other

3.39k stars 529 forks source link

HttpListenInput alters received data with url.QueryUnescape #1124

Closed simonpasquier closed 9 years ago

simonpasquier commented 10 years ago

I see no reason why HttpListenInput calls url.QueryUnescape() on the received body [1]. As such if the data contains '+' characters, they will be transformed as ' '. And any data containing a '%' character not followed by two hexadecimal digits will be dropped.

[1] https://github.com/mozilla-services/heka/blob/dev/plugins/http/http_listen_input.go#L86

asenchi commented 10 years ago

Related to this, it appears this causes issues with environment variables as well:

2014-11-06_17:25:10.27896 2014/11/06 17:25:10 Initialization failed for 'logsearch': Unable to parse ElasticSearch server URL [http://logsearch-data.%ENV[ENV]:9200]: parse http://logsearch-data.%ENV[ENV]:9200: hexadecimal escape in host

rafrombrc commented 9 years ago

Closed in #1190.