search

mozilla-services / heka

DEPRECATED: Data collection and processing made easy.
http://hekad.readthedocs.org/
Other
3.39k stars 531 forks source link

Update lua_sandbox, add max-depth and sep-char to JsonDecoder #1872

Closed nathwill closed 8 years ago

rafrombrc commented 8 years ago

Closes #1809.

nathwill commented 8 years ago

@rafrombrc i'm not sure why exactly, but there does seem to be something weird with the nesting... the test matches experimental results but GetFieldValue("nested1-field") keeps getting nil, so those 2 tests are failing :crying_cat_face:, still digging, but if you have any pointers, i'd appreciate it.

rafrombrc commented 8 years ago

Test was failing b/c sandbox config expects number values to be type int64 or float64, unspecified is type int. I fixed this, changed the name of the setting from separator_char to separator, and added a changelog entry. Merging now. Thanks for tackling this!

nathwill commented 8 years ago

awesome, thanks Rob!