BIND query log decoder Lua plugin

mozilla-services / heka

DEPRECATED: Data collection and processing made easy.

http://hekad.readthedocs.org/

Other

3.4k stars 531 forks source link

BIND query log decoder Lua plugin #1916

Closed nickchappell closed 8 years ago

nickchappell commented 8 years ago

@rafrombrc @trink do you want this squashed into a single commit?

sathieu commented 8 years ago

Hello @nickchappell ,

The parser should probably go to lua_sandbox, to be available to other tools.

nickchappell commented 8 years ago

@trink should I close this PR and open one up against https://github.com/mozilla-services/lua_sandbox/ ?

trink commented 8 years ago

The PR against heka is actually fine for the moment it will be easier to migrate everything from one place.

nickchappell commented 8 years ago

@trink should the refactor to make the grammar a module wait until then as well, or should I do that now? If it should be modular-ized now, are there any examples of existing modules I should follow?

trink commented 8 years ago

It should be modularized now. Here is an example: https://github.com/mozilla-services/lua_sandbox/blob/master/modules/ip_address.lua

nickchappell commented 8 years ago

Would you have to write another Lua script that calls the modular-ized BIND decoder in order to actually use the grammar?

nickchappell commented 8 years ago

@trink I addressed the issues you mentioned in the inline comments, minus the hostname grammar refactor, as you mentioned that would be taken care of in #129. Do you want me to squash all of the commits?

trink commented 8 years ago

Yes please squash them

nickchappell commented 8 years ago

@trink @rafrombrc Commits have been squashed.

nickchappell commented 8 years ago

@trink anything else needed so this can be merged?

nickchappell commented 8 years ago

@trink any updates?

nickchappell commented 8 years ago

@trink @rafrombrc Any update on getting this merged?

trink commented 8 years ago

@nickchappell Sorry for the delay, this request is in a state of limbo as it will need to be refactored and moved to the lua_sandbox in the very near future. @rafrombrc thoughts?

merge now and migrate later?
turn it into a grammar module for the new sandbox and have it available when the integration with Heka is complete?
??

nickchappell commented 8 years ago

Hi @trink,

It should already be modular-ized. I think you mentioned earlier that this could be merged into Heka now and then added to the new sandbox at some point later.

nickchappell commented 8 years ago

Thanks!

trink commented 8 years ago

The module has to be pulled out and placed in the modules directory and the decoder has to require it and implement the expected sandbox API. The question above was for Rob to determine timeline/frame and where the work should be committed (I guess he is fine with Heka, so it should be fixed there).

rafrombrc commented 8 years ago

Yes, sorry, I misinterpreted the thread as an r+ from Trink, so I merged. Happy to have it land in Heka for now.