search

mozilla-services / heka

DEPRECATED: Data collection and processing made easy.
http://hekad.readthedocs.org/
Other
3.4k stars 531 forks source link

HttpOutput does not respect http_proxy environment variable #1929

Open gravaton opened 8 years ago

gravaton commented 8 years ago

When attempting to use HttpOutput to push messages to an endpoint outside our corporate network, it attempts to connect directly. Go's documentation implies that the http_proxy environment variable should be respected however it does not seem to be. The Nagios Output plugin seems to have some capability for proxying but the HttpOutput plugin does not.

michaelgibson commented 7 years ago

I think....this would be as simple as adding Proxy: http.ProxyFromEnvironment, From: https://github.com/mozilla-services/heka/blob/dev/plugins/nagios/nagios_output.go#L94 To: https://github.com/mozilla-services/heka/blob/dev/plugins/http/http_output.go#L81

But haven't tested it.