search

mozilla-services / heka

DEPRECATED: Data collection and processing made easy.
http://hekad.readthedocs.org/
Other
3.4k stars 531 forks source link

Fix Sarama Dependency #1931

Closed relistan closed 8 years ago

relistan commented 8 years ago

The current dev branch won't compile because it is using TLS settings which are not available in the forked Sarama which is currently in the cmake setup. This moves to the upstream which lets the branch compile.

relistan commented 8 years ago

I can't quite understand what Travis is failing on here.

rafrombrc commented 8 years ago

I'm not quite sure what's going on here. I'm not necessarily opposed to merging this, but the dev branch is building just fine for me, and I also don't understand why the Travis build is failing. What's the build failure you're seeing?

relistan commented 8 years ago

Clearly something stale in my build environment as I'm now unable to reproduce this issue from dev. Closing because it does seem to be working indeed, and I am not keen on sorting out what Travis is unhappy about. Sorry 'bout that.

relistan commented 8 years ago

Hmm, just hit this again. Something is weird in the build chain:

[100%] Built target mocks
heka/src/github.com/mozilla-services/heka/plugins/kafka/kafka_input.go:28:2: cannot find package "github.com/Shopify/sarama" in any of:
    /usr/local/go/src/github.com/Shopify/sarama (from $GOROOT)
    /home/kmatthias/heka/build/heka/src/github.com/Shopify/sarama (from $GOPATH)
make[2]: *** [CMakeFiles/hekad] Error 1
make[1]: *** [CMakeFiles/hekad.dir/all] Error 2
make: *** [all] Error 2

There appears to be some kind of ordering issue that occasionally rears its head.