search

mozilla-services / kinto-dist

Kinto Distribution for Mozilla Services
Apache License 2.0
12 stars 11 forks source link

Restore version fields signer and changes capabilities metadata #1944

Closed leplatrem closed 2 years ago

leplatrem commented 2 years ago

This works only if kinto-dist is installed with pip install -e . which we don't do. We'd have to find another approach. Hard-coding?

grahamalama commented 2 years ago

This works only if kinto-dist is installed with pip install -e . which we don't do. We'd have to find another approach. Hard-coding?

Maybe we should do this. It feels a little less hacky than manually adding kinto_remote_settings to the PYTHONPATH. Thoughts?

grahamalama commented 2 years ago

@leplatrem I rebased this branch on main to account for #1934. Since it included breaking changes, I modified the changelog so that we'll be releasing a new major version 27 for the next release, which will include the bugfixes that were addressed in this PR.

I also added a hardcoded version value as we discussed on our call today.

leplatrem commented 2 years ago

Works for me.

I know it's only a temporary step, but we could still update the paragraph about releasing in the README

grahamalama commented 2 years ago

Works for me.

I know it's only a temporary step, but we could still update the paragraph about releasing in the README

Good call https://github.com/mozilla-services/kinto-dist/pull/1944/commits/fad7aa9c020a3adad65906229b65c0825dec710d

leplatrem commented 2 years ago

r+

grahamalama commented 2 years ago

bors merge

bors[bot] commented 2 years ago

Canceled.