search

mozilla-services / kinto-dist

Kinto Distribution for Mozilla Services
Apache License 2.0
12 stars 11 forks source link

Remove configurable group name #1945

Closed leplatrem closed 2 years ago

leplatrem commented 2 years ago

Now that kinto-signer is remote-settings, we can remove useless settings, like for example the ability to configure the group names at various levels.

We could just have a default value set to:

kinto.signer.editors_group = {collection_id}-editors
kinto.signer.reviewers_group = {collection_id}-reviewers

Caution: we may have to maintain some metadata in the capabilities, since it's used by Kinto Admin. See https://github.com/Kinto/kinto-admin/blob/e5792ea176192d42d61086588f9622e40876ee9b/src/plugins/signoff/components.tsx#L22-L38

leplatrem commented 2 years ago

Moved to https://github.com/mozilla/remote-settings/issues/149