The editors group is used to limit the users allowed to request review on a collection.
We don't really need that. Being able to write on the collection is enough to be allowed to request review. And there is no reason why a reviewer could not request a review too (since they have write perms on the collection).
This would allow to remove a lot of duplicated lists in our permissions manifests, because for collections whose group of editors is the same as reviewers, we would just have:
leplatrem
commented
2 years ago
The editors group is used to limit the users allowed to request review on a collection.
We don't really need that. Being able to write on the collection is enough to be allowed to request review. And there is no reason why a reviewer could not request a review too (since they have write perms on the collection).
This would allow to remove a lot of duplicated lists in our permissions manifests, because for collections whose group of editors is the same as reviewers, we would just have:
And for the collections which have editors that are not reviewers, we would do:
This issue was initially reported here https://github.com/Kinto/kinto-signer/issues/733
But it makes more sense to keep track of it here, along with #1945, #1946, #1948.