search

mozilla-services / kinto-dist

Kinto Distribution for Mozilla Services
Apache License 2.0
12 stars 11 forks source link

Run integration tests on any server #1965

Closed leplatrem closed 2 years ago

leplatrem commented 2 years ago

Follow-up of #1927

We should make sure (and document) how to run the integration on any server providing the appropriate environment variables and setup.

For example, in our DEV/STAGE server we could have a dedicated user (account:integration-test) and collection (product-integrity), and run the full integration suite.

The suite would skip bucket, collection, and user creation, clear all the collection records, and execute the whole test suite.

This would replace the current https://github.com/mozilla-services/kinto-integration-tests/ which is basically useless

leplatrem commented 2 years ago

Detail spotted while working on #1964 :

https://github.com/mozilla-services/kinto-dist/blob/7b97bfaccbd56b169b7de0cbae18b2ea83adbade/tests/integration_test.py#L190

Instead, it would be recommended to check whether the user is already a member (and keep existing members in the patch, or use JSONPatch)

https://github.com/mozilla-services/kinto-dist/blob/7b97bfaccbd56b169b7de0cbae18b2ea83adbade/kinto-remote-settings/tests/signer/functional.py#L591-L593

leplatrem commented 2 years ago

moved to https://github.com/mozilla/remote-settings/issues/152