search

mozilla-services / lua_sandbox

Generic Lua sandbox for dynamic data analysis
Other
227 stars 71 forks source link

some Firefox OS user agents not parsed correctly #53

Closed kparlante closed 9 years ago

kparlante commented 9 years ago

@trink : We noticed a bunch of Firefox 18's (with no user_agent_os) in the logs (coming from Marketplace). @whd pulled up the user agent string: Mozilla/5.0 (Mobile; ALCATELOneTouch4012A; rv:18.1) Gecko/18.1 Firefox/18.1. Looks like the parser is missing this: https://github.com/mozilla-services/lua_sandbox/blob/dev/modules/common_log_format.lua#L314-331

fwiw, here's one of the dashboards where they show up: https://kibana.fxa.us-west-2.prod.mozaws.net/index.html#/dashboard/file/oauth_http_status.json

trink commented 9 years ago

So do you just want to relax "Mozilla/5.0 (Mobile; rv:" to "Mozilla/5.0 (Mobile;" and return FirefoxOS?

kparlante commented 9 years ago

@trink: yes