mozilla-services / lua_sandbox_extensions

Extension packages (sandboxes and modules) for the lua_sandbox project
Other
72 stars 55 forks source link

[taskclusteretl] Add default management chain for unknown identities #516

Closed srfraser closed 4 years ago

srfraser commented 4 years ago

When rolling up the costs based on the org chart, a lot of costs are orphaned:

  1. Collaborators
  2. Github CI activity where a person's Github username isn't on people.m.o
  3. Other activity from people in the org chart but who are using other identities for commits

Since the bulk of these is likely collaborators, this change adds a default in the situation where the join with person_mozilla_com produces no management chain. Adding the CEO allows the total in the reports to line up with the data that doesn't sort things this way, and reinforces the idea that they're ultimately accountable for the cost. The fake manager "Collaborator" acts as an intermediary to avoid polluting the CEO's direct reports and lets us view these other identities as a group.

(I've not yet deployed these changes)