search

mozilla-services / merino

Web service for Firefox Suggest
https://mozilla-services.github.io/merino/
Mozilla Public License 2.0
31 stars 5 forks source link

Make sure Merino log lines specify a `type` #188

Closed data-sync-user closed 2 years ago

data-sync-user commented 2 years ago

mozlog, which is used in Merino for structured logging, provides a type field. We'll use this type field to route log lines toward a sensitive and a non-sensitive environment. We should make sure that log levels less or equal than INFO (e.g. WARN) specify a type, so that we don't mistakenly send them to the wrong place.

┆Issue is synchronized with this Jira Task

data-sync-user commented 2 years ago

➤ Ron Manning commented:

Michael Cooper to add Blockers to this ticket.

data-sync-user commented 2 years ago

➤ Alessio Placitelli commented:

Michael Cooper was this done in some PR already, or do we need to audit the code still?

data-sync-user commented 2 years ago

➤ Michael Cooper commented:

This has not been done. Ethan Donowitz and I looked a bit into ways that we could introduce debug-runtime checks for this, and ran into limitations of Tracing and our integration with it.

At this point a manual audit is probably our best way forward, but it makes it difficult to deal with any library logging.