mozilla-services / metlog-py

INACTIVE - http://mzl.la/ghe-archive - Python library for Services metrics logging
36 stars 8 forks source link

Vng/pluginconfig #8

Closed crankycoder closed 12 years ago

rafrombrc commented 12 years ago

This is awesome, thanks! Just a couple of thoughts:

First, I'm thinking this is possible and maybe even a bit easier to use by scrapping the entry points thing altogether and just specifying all of the info in the config, like so:

[metlog_plugin_dummy]
provider = metlog.tests.plugin.config_plugin
port = 8080
host = localhost

The method name would extracted from the config section name (i.e. "metlogplugin") and the configurator is specified as the provider value. Would this work, or am I missing something?

The second point is just a documentation nit. I'd love to see the (very well written, thank you!) "plugins" section above the "dictionary format" section, next to the rest of the ini file stuff, and then the dictionary section should be updated to reflect the dictionary representation of the same config.