Add `previous_os_version` to `default-browser-agent/default-browser`.

mozilla-services / mozilla-pipeline-schemas

Schemas for Mozilla's data ingestion pipeline and data lake outputs

https://protosaur.dev/mps-deploys/

Other

46 stars 91 forks source link

Add `previous_os_version` to `default-browser-agent/default-browser`. #802

Closed ncalexan closed 5 months ago

ncalexan commented 5 months ago

This completes https://bugzilla.mozilla.org/show_bug.cgi?id=1850149 for Legacy telemetry. (Glad I realized this was necessary before it made it to release channel!)

Checklist for reviewer:

[ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
[ ] If adding a new field, the field should have a description (see #576 for an example)
[ ] If coming from a fork, run integration tests: ./.github/push-to-trigger-integration <username>:<branchname>

For glean changes:

[ ] Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

[ ] Follow the change control procedure

ncalexan commented 5 months ago

I'm frustrated that this means that I have to run a bunch of stuff locally because I made the initial patch in the Github Web UI to avoid cloning :( I'll get to this when I can.

scholtzan commented 5 months ago

I created a new PR with the generated schemas (https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/803)

fbertsch commented 5 months ago

@ncalexan just to be clear here - we don't recommend using the legacy telemetry tools here in this repo (for this reason and others). When you use Glean there is no need to do anything manual in the pipeline, and we have a similar generation mechanism for the main ping probes. We understand that it is frustrating, which is why we created tools to remove this step!

ncalexan commented 5 months ago

@ncalexan just to be clear here - we don't recommend using the legacy telemetry tools here in this repo (for this reason and others). When you use Glean there is no need to do anything manual in the pipeline, and we have a similar generation mechanism for the main ping probes. We understand that it is frustrating, which is why we created tools to remove this step!

Totally understood, and we're using Glean in parallel to this legacy telemetry until we can switch over entirely.

My frustration is with the repo layout which has checked in genereated artifacts, increasing the cost of making a change yet further. But I can understand that there won't be movement here, what with the trend towards Glean and better tooling across the board.