mozilla-services / mozilla-pipeline-schemas

Schemas for Mozilla's data ingestion pipeline and data lake outputs
https://protosaur.dev/mps-deploys/
Other
46 stars 91 forks source link

Bug 1892312 - Add `recoveredFromBackup` to environment schema. #814

Closed mikeconley closed 3 weeks ago

mikeconley commented 1 month ago

Unfortunately, when attempting to run the build scripts to run the tests, I got this error:

 => CACHED [stage-0  2/15] RUN set -eux;     apt-get update;     apt-get install -y --no-install-recommends         ca-certificates         gcc         libc6-dev         wget         ;     dpkgArch="$(dpkg --print-architecture)";     case "${dpkgArch##*-  0.0s
 => CACHED [stage-0  3/15] RUN mkdir -p /usr/share/man/man1 &&     apt-get update -qqy &&     apt-get install -qqy         cmake         diffutils         gcc         g++         jq         make         wget         git         openjdk-11-jdk-headless     0.0s
 => CACHED [stage-0  4/15] RUN cargo install jsonschema-transpiler --version 1.9.0                                                                                                                                                                              0.0s
 => CACHED [stage-0  5/15] RUN git config --global user.email "mozilla-pipeline-schemas@mozilla.com"                                                                                                                                                            0.0s
 => CACHED [stage-0  6/15] RUN git config --global user.name "Mozilla Pipeline Schemas"                                                                                                                                                                         0.0s
 => CACHED [stage-0  7/15] WORKDIR /app                                                                                                                                                                                                                         0.0s
 => CACHED [stage-0  8/15] COPY --from=mozilla/ingestion-sink:latest /app/ingestion-sink/target /app/target                                                                                                                                                     0.0s
 => CACHED [stage-0  9/15] COPY requirements.txt requirements-dev.txt ./                                                                                                                                                                                        0.0s
 => CACHED [stage-0 10/15] RUN pip3 install --upgrade pip setuptools &&     pip3 install -r requirements.txt -r requirements-dev.txt                                                                                                                            0.0s
 => CACHED [stage-0 11/15] COPY pom.xml .                                                                                                                                                                                                                       0.0s
 => CACHED [stage-0 12/15] RUN mvn dependency:copy-dependencies                                                                                                                                                                                                 0.0s
 => CACHED [stage-0 13/15] COPY . /app                                                                                                                                                                                                                          0.0s
 => CACHED [stage-0 14/15] RUN pip3 install .                                                                                                                                                                                                                   0.0s
 => CACHED [stage-0 15/15] RUN mkdir release &&     cd release &&     cmake .. &&     make                                                                                                                                                                      0.0s
 => ERROR exporting to image                                                                                                                                                                                                                                    0.0s
 => => exporting layers                                                                                                                                                                                                                                         0.0s
 => => writing image sha256:cee25823f9058e5260effc2e4979eddbe02a6f46afb9f35626792f5a7f40f604                                                                                                                                                                    0.0s
------
 > exporting to image:
------
ERROR: failed to solve: operating system is not supported

So I'm afraid I haven't been able to run the tests to make sure they still pass.

Checklist for reviewer:

For glean changes:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

BenWu commented 3 weeks ago

@mikeconley Is this still needed? This has been inactive for a month but I'm guessing it is. We've only received environment.profile.recoveredFromBackup eight times in the past month so not much has been missed.

For the tests, you can try docker build -t mozilla-pipeline-schemas:latest . instead of ./scripts/mps-build, assuming you're using an apple cpu. The script adds --platform=amd64 which doesn't work for me. The tests passed in CI already though so it's fine this time

mikeconley commented 3 weeks ago

Thanks, @BenWu! Yes, using docker build -t mozilla-pipeline-schemas:latest . worked, and I was able to run the tests, which pass. I've also rebased on main.

mikeconley commented 3 weeks ago

And yes, we'd still very much like this!