search

mozilla-services / mozservices

INACTIVE - http://mzl.la/ghe-archive - Various utilities for Pyramid-based Mozilla applications
33 stars 17 forks source link

add helper function mozsvc.config.load_into_settings #1

Closed rfk closed 13 years ago

rfk commented 13 years ago

Thoughts?

By the way, I hope everyone's happy with using pull-requests for code review like this - if you think it's not worth it at these early stages of development, feel free to tell me to "just shut up and merge" :-)

tarekziade commented 13 years ago

Looks good ! It could have a test I guess

About the pull-request process: I think it's a good idea. I should do that too

tarekziade commented 13 years ago

Looks good ! It could have a test I guess

About the pull-request process: I think it's a good idea. I should do that too

tarekziade commented 13 years ago

Looks good ! It could have a test I guess

About the pull-request process: I think it's a good idea. I should do that too

tarekziade commented 13 years ago

Looks good ! It could have a test I guess

About the pull-request process: I think it's a good idea. I should do that too

tarekziade commented 13 years ago

Looks good ! It could have a test I guess

About the pull-request process: I think it's a good idea. I should do that too

tarekziade commented 13 years ago

Looks good ! It could have a test I guess

About the pull-request process: I think it's a good idea. I should do that too

tarekziade commented 13 years ago

Looks good ! It could have a test I guess

About the pull-request process: I think it's a good idea. I should do that too

tarekziade commented 13 years ago

there's a bug in github. I cannot merge the pull request for some reason, and well, you've seen... the comments get posted many times :s