Closed rfk closed 13 years ago
Looks good ! It could have a test I guess
About the pull-request process: I think it's a good idea. I should do that too
Looks good ! It could have a test I guess
About the pull-request process: I think it's a good idea. I should do that too
Looks good ! It could have a test I guess
About the pull-request process: I think it's a good idea. I should do that too
Looks good ! It could have a test I guess
About the pull-request process: I think it's a good idea. I should do that too
Looks good ! It could have a test I guess
About the pull-request process: I think it's a good idea. I should do that too
Looks good ! It could have a test I guess
About the pull-request process: I think it's a good idea. I should do that too
Looks good ! It could have a test I guess
About the pull-request process: I think it's a good idea. I should do that too
there's a bug in github. I cannot merge the pull request for some reason, and well, you've seen... the comments get posted many times :s
Thoughts?
By the way, I hope everyone's happy with using pull-requests for code review like this - if you think it's not worth it at these early stages of development, feel free to tell me to "just shut up and merge" :-)