The FunctionalTestCase class commits the configurator (implicity via make_wsgi_app) when it's running against an in-memory configuration, but not when it's running against a live server. It should do it consistently across both branches, so that it can be used to e.g. look up the appropriate authentication policy classes.
This looks fine to me. As for the clarity issue, a comment on the self.config.make_wsgi_app line mentioning that it calls commit would suffice. Regardless, r+.
The FunctionalTestCase class commits the configurator (implicity via make_wsgi_app) when it's running against an in-memory configuration, but not when it's running against a live server. It should do it consistently across both branches, so that it can be used to e.g. look up the appropriate authentication policy classes.
@rafrombrc r?