search

mozilla-services / mozservices

INACTIVE - http://mzl.la/ghe-archive - Various utilities for Pyramid-based Mozilla applications
33 stars 17 forks source link

Commit the configurator when running functional tests. #23

Closed rfk closed 12 years ago

rfk commented 12 years ago

The FunctionalTestCase class commits the configurator (implicity via make_wsgi_app) when it's running against an in-memory configuration, but not when it's running against a live server. It should do it consistently across both branches, so that it can be used to e.g. look up the appropriate authentication policy classes.

@rafrombrc r?

rafrombrc commented 12 years ago

This looks fine to me. As for the clarity issue, a comment on the self.config.make_wsgi_app line mentioning that it calls commit would suffice. Regardless, r+.

rfk commented 12 years ago

Committed with some clarifying comments in d790ee4a0f