Fix getOIDForEncryptionAlgorithm to support crypto.Signer from HSM

mozilla-services / pkcs7

DEPRECATED - Implements a subset of PKCS#7/Cryptographic Message Syntax (rfc2315, rfc5652)

https://go.mozilla.org/pkcs7

MIT License

70 stars 92 forks source link

Fix getOIDForEncryptionAlgorithm to support crypto.Signer from HSM #41

Closed mekpavit closed 9 months ago

mekpavit commented 4 years ago

This pull request fix getOIDForEncryptionAlgorithm in pkcs7.go check type of public key instead of private key if the pkey implements crypto.Signer. This should make this library compatible with crpyto.Signer that does not expose private key (for example, crpyto.Signer from ThalesIgnite/crypto11 that holds the signer from HSM).

Change

Fix getOIDForEncryptionAlgorithm to check for crypto.Signer first. if it is crypto.Signer, it will determine OIDForEncryptionAlgorithm from the public key.

Kuenni commented 3 years ago

Please, merge this PR. We could very well use this improvement! :) THX

kuhlmannmarkus commented 3 years ago

Thank you for this solution @mekpavit! We have been looking for a solution like this for some time now. Can somebody merge this, please?

RichardLaos commented 2 years ago

Great solution @mekpavit. Would be happy to have this merged as well.

jessepeterson commented 2 years ago

Apologies for the direct ping @g-k (or other project maintainers) but is there any chance this could get merged? We're maintaining a fork just for this change. Thanks!

AlCutter commented 9 months ago

Hi @g-k (or others), we could really do with this being merged too - any chance of it going in? Thanks!

jvehent commented 9 months ago

@g-k and myself no longer work at mozilla and therefore no longer maintain this repository. perhaps @hwine can be of assistance?

jessepeterson commented 9 months ago

@AlCutter I'd suggest taking a look at the smallstep/pkcs7#3 fork (and that issue that mentions this one). They're more actively maintaining it over there. Also see #73 in this repo.