fixes ber decoding with longer certs

manavk-p commented 3 years ago

Allows for longer certs, such as some AWS certs, to be decoded properly. Taken from https://github.com/fullsailor/pkcs7/pull/17

manavk-p commented 3 years ago

@ jvehent This PR pulls in a change from a PR to fullsailor's repo. It allows for longer certs to be decoded without error.

bernata commented 3 years ago

@g-k there are still some issues with this PR; the go.mod in particular and i think it would be useful to have a real cert that demonstrates the need for this fix. If I fix those two issues [or more if you have them], do you feel it would be ok to merge?

g-k commented 3 years ago

@bernata Yes, I can take look, but I won't get to it until at least the end of the month.

Can you open a new PR with:

[ ] a fixed go.mod
[ ] a test with a real cert ideally from a well known service
[ ] https://github.com/fullsailor/pkcs7/pull/17/commits/d25ebd6320a9025082b7e0a90b0309ca913c6266 cherry picked from upstream
[ ] if applicable, tests from this branch https://github.com/mozilla-services/pkcs7/pull/53/commits/632789f937e492631c53b15f54881116148dce0d (but not the merge back into master https://github.com/mozilla-services/pkcs7/pull/53/commits/db74de8bc4fc343ec35c85c8b573b16380bfcf9e)

Thanks!

g-k commented 3 years ago

Superseded by #61

mozilla-services / pkcs7

fixes ber decoding with longer certs #53