search

mozilla-services / push-dev-dashboard

Developer dashboard for the Mozilla web push service
https://dev-dashboard.deis.dev.mozaws.net/
Mozilla Public License 2.0
7 stars 6 forks source link

bug 1258856 - remove pontoon.js #161

Closed groovecoder closed 8 years ago

groovecoder commented 8 years ago

We don't need to do in-page pontoon.js to increase translation rate, so we can remove the pontoon.js script.

codecov-io commented 8 years ago

Current coverage is 91.13%

Merging #161 into master will decrease coverage by -0.01% as of ae3ca1b

@@            master    #161   diff @@
======================================
  Files           42      42       
  Stmts          870     869     -1
  Branches        27      27       
  Methods          0       0       
======================================
- Hit            793     792     -1
  Partial          8       8       
  Missed          69      69

Review entire Coverage Diff as of ae3ca1b

Powered by Codecov. Updated on successful CI builds.

openjck commented 8 years ago

Funny that this says code coverage will decrease given that you're only removing code...

openjck commented 8 years ago

r+

In-page localization would be great in the future, but if it's going to take more work I agree out-of-context localization is a good first step.