search

mozilla-services / push-dev-dashboard

Developer dashboard for the Mozilla web push service
https://dev-dashboard.deis.dev.mozaws.net/
Mozilla Public License 2.0
7 stars 6 forks source link

Add __heartbeat__ and __lbheartbeat__ endpoints #177

Closed oremj closed 8 years ago

oremj commented 8 years ago

Fixes #176

codecov-io commented 8 years ago

Current coverage is 93.52%

Merging #177 into master will increase coverage by +0.04% as of 4dcf941

@@            master    #177   diff @@
======================================
  Files           43      43       
  Stmts          906     911     +5
  Branches        27      27       
  Methods          0       0       
======================================
+ Hit            847     852     +5
  Partial          9       9       
  Missed          50      50

Review entire Coverage Diff as of 4dcf941

Powered by Codecov. Updated on successful CI builds.

groovecoder commented 8 years ago

This is looking good. I'll spot-check it on Monday and merge it then.

groovecoder commented 8 years ago

Works. But, the __lbheartbeat__ endpoint connects to the backing database service, even though the Dockerflow docs say that it shouldn't? Is that okay?

Also, I'm going to try to add onto this branch to put the heartbeat URL(s) into a HEALTHCHECK_URL environment variable - the Deis convention for kubernetes container probes.

groovecoder commented 8 years ago

Superseding with https://github.com/mozilla-services/push-dev-dashboard/pull/178 ... we can update that branch together.