search

mozilla-services / push-dev-dashboard

Developer dashboard for the Mozilla web push service
https://dev-dashboard.deis.dev.mozaws.net/
Mozilla Public License 2.0
7 stars 6 forks source link

Add sentry integration for traceback reporting #189

Closed oremj closed 8 years ago

oremj commented 8 years ago

Fixes #188

oremj commented 8 years ago

@groovecoder r?

codecov-io commented 8 years ago

Current coverage is 93.45%

Merging #189 into master will decrease coverage by -0.30% as of 469a7e2

@@            master    #189   diff @@
======================================
  Files           43      43       
  Stmts          944     948     +4
  Branches        30      31     +1
  Methods          0       0       
======================================
+ Hit            885     886     +1
- Partial          9      10     +1
- Missed          50      52     +2

Review entire Coverage Diff as of 469a7e2

Powered by Codecov. Updated on successful CI builds.

groovecoder commented 8 years ago

Looks good. I added this to https://github.com/mozilla-services/push-dev-dashboard/issues/147 and I'll spot-check it now to make sure there are no regressions.

groovecoder commented 8 years ago

No issues ... is this config known work for other django projects? How can I test? Can I set this env var to a dev sentry server on the dev dashboard instance to check it?

oremj commented 8 years ago

It should be good. I got the config from https://getsentry.com/for/django/. We do something similar for AMO. I'll test on stage shortly.

groovecoder commented 8 years ago

Would I be able to send dev server/instance/cluster tracebacks to the stage sentry server too?

oremj commented 8 years ago

@jasonthomas ^?

jasonthomas commented 8 years ago

This should be fine. We just need to create a unique project just for the dev instance.