mozilla-services / push-dev-dashboard

Developer dashboard for the Mozilla web push service
https://dev-dashboard.deis.dev.mozaws.net/
Mozilla Public License 2.0
7 stars 6 forks source link

fix #215: add GA event for finished sign-in #216

Closed groovecoder closed 8 years ago

groovecoder commented 8 years ago

@clarkbw - please check this and verify these are good event category, action, and label values for Google Analytics. I can make them whatever we want, but we should be sure about them now so we can maintain the data integrity after launch.

clarkbw commented 8 years ago

👍 Looks good. Is there any error actions available?

groovecoder commented 8 years ago

We won't know if there are errors happening on the FxA sign-in page. Let me see if I can record if/when a user gets an error from the dashboard after getting back from FxA ...

groovecoder commented 8 years ago

Okay, I added a GA event if/when the user gets a dashboard error page after trying to sign in with Firefox Accounts. The only way I could trigger this was to corrupt my FxA Oauth Client Secret, so I don't expect we'll see this error much at all once everything is set up.

codecov-io commented 8 years ago

Current coverage is 92.38%

Merging #216 into master will not change coverage

@@             master       #216   diff @@
==========================================
  Files            46         46          
  Lines          1076       1076          
  Methods           0          0          
  Messages          0          0          
  Branches         37         37          
==========================================
  Hits            994        994          
  Misses           72         72          
  Partials         10         10          

Powered by Codecov. Last updated by 44e3cb0...4943f06