search

mozilla-services / pushbox

Durable Storage for Push
Mozilla Public License 2.0
6 stars 9 forks source link

Accept a passthru request/trace id from FxA auth server #24

Closed pjenvey closed 6 years ago

pjenvey commented 6 years ago

Pushbox should optionally accept some kind of trace id via a header from services sending it requests (e.g. fxa-auth-server). For use to trace a pushbox request to the parent services request.

We're not using any tracing framework like AWS XRay, so just logging the id if one is present is fine for now.

(Does fxa have a standard for passing such things around to its microservices?)

jrconlin commented 6 years ago

@rfk What identifier should I look for?

rfk commented 6 years ago

(Does fxa have a standard for passing such things around to its microservices?)

It doesn't. Let's use X-Request-ID, which seems to be an ad-hoc standard supported by at least a few different sets of tooling in the node ecosystem.

jrconlin commented 6 years ago

Hrm. I've been informed that using the X- prefix is frowned upon among the modern spec folk.

Perhaps we can be a bit more explicit and just call it a FxA-Request-ID or something?