mozilla-services / pushbox

Durable Storage for Push
Mozilla Public License 2.0
6 stars 9 forks source link

read_opt query parameters not correctly parsed #61

Closed pjenvey closed 4 years ago

pjenvey commented 4 years ago

Rocket 0.4 may have changed its query parameter handling (or maybe this didn't work under 0.3 either), but read_opt isn't getting the full query parameter string it expects from its ?<opt_str> route directive.

pjenvey commented 4 years ago

Looks like it was indeed due to Rocket 0.4 changes here https://github.com/SergioBenitez/Rocket/issues/608

vladikoff commented 4 years ago

@pjenvey do you know why this issue is not in Prod? 🤔

pjenvey commented 4 years ago

@pjenvey do you know why this issue is not in Prod?

the release on prod is much older, it's still using rocket 0.3.