Closed tublitzed closed 3 years ago
Rocket 0.4 still requires nightly (and is the version currently in use). Rocket 0.5 (unreleased) will no longer require nightly.
Here's the GitHub milestone tracking 0.5 progress: https://github.com/SergioBenitez/Rocket/milestone/8
Thanks Mark!
We should still migrate to 0.4, since we're on a pretty old version of rocket as is.
According to Cargo.lock
it's using 0.4.5 0.4.4 while the latest version is 0.4.5, so there is an update to be made but it's just a patch update.
Edit: The lock file is always more accurate; it's actually using 0.4.5, which is the latest version.
I'm going to suggest that this issue is still accurate, but that the scope and target are going to be vastly different.
Pushbox is written with a lot of legacy. Rocket, currently, is not.
In order to get Pushbox over onto the latest Rocket the following will probably be required:
on_request
is more about modifying incoming Request and Payload data. failure
error handlers with modern thiserror
& anyhow
etc.* Convert futures 0.1 to modern async/await
I didn't think there was any async in pushbox
Not in pushbox directly, but recent versions of rusoto are all async, so we should couch those calls correctly.