Feature/router interface refactor

mozilla-services / pushgo

🚨🚨🚨OBSOLETE AND UNMAINTAINED🚨🚨🚨 See Autopush for the current server.

https://github.com/mozilla-services/autopush

Mozilla Public License 2.0

24 stars 10 forks source link

Feature/router interface refactor #154

Closed bbangert closed 9 years ago

bbangert commented 9 years ago

This PR changes Router to an interface, add's registration functions for the server to trigger the router on UAID changes, and a Start/Close scheme for any other things a Router needs to manage.

It also introduces the use of Goconvey and gomock along with most of the mocked interfaces for easier testing.

Closes #127.

@jrconlin, @kitcambridge, r?

ghost commented 9 years ago

Looks great, @bbangert. r+ from me; will wait for @jrconlin to finish reviewing.

jrconlin commented 9 years ago

r+ as well.