search

mozilla-services / pushgo

🚨🚨🚨OBSOLETE AND UNMAINTAINED🚨🚨🚨 See Autopush for the current server.
https://github.com/mozilla-services/autopush
Mozilla Public License 2.0
24 stars 10 forks source link

Include the EC2 instance ID in `/realstatus` #193

Closed ghost closed 9 years ago

ghost commented 9 years ago

@rpappalax requested an easier way to see the EC2 hostname for SSH access. I think exposing http://169.254.169.254/latest/meta-data/local-hostname is safe; AIUI, it's just not meaningful unless you already have access to the Bastion host.

@oremj r?

oremj commented 9 years ago

This seems fine to me. Alternatively, we could expose instance-id, to quickly look it up in the management interface.

ghost commented 9 years ago

I like exposing the instance ID. @rpappalax, do you have a preference?

jrconlin commented 9 years ago

+1 on exposing the instance ID over the IP. In theory, we shouldn't be ssh'ing or targeting the specific machine and having the instance ID makes it all the more compelling not to do so.

bbangert commented 9 years ago

r-, pending resp.Body close (aware this was a problem before this PR, but might as well fix it now).

bbangert commented 9 years ago

r+