search

mozilla-services / pushgo

🚨🚨🚨OBSOLETE AND UNMAINTAINED🚨🚨🚨 See Autopush for the current server.
https://github.com/mozilla-services/autopush
Mozilla Public License 2.0
24 stars 10 forks source link

Wait until the locator is ready before accepting client connections #201

Closed ghost closed 9 years ago

ghost commented 9 years ago

This pull request adds an optional ReadyNotifier interface that locators can use to defer accepting client connections. Closes #111.

bbangert commented 9 years ago

Looks like it will probably work, but it'd be nice to have a test for a little more confidence. I have the sad thought that it will take more work to come up with a test.

ghost commented 9 years ago

I have the sad thought that it will take more work to come up with a test.

Yes. :smile_cat: Some of the fake helpers for #179 might be useful here; I'll take a look in a bit.

ghost commented 9 years ago

Added tests, and fixed an issue where we were waiting for the full timeout if no one accepted a routed update. I think that should reduce some of the latency spikes we were seeing in the load tests.

This uses the mock helpers from #211; the commit set should look a lot cleaner once that's merged.

bbangert commented 9 years ago

r-, pending naming nit

bbangert commented 9 years ago

r+